Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download a re-run folder, and it gets rendered images too. #210

Merged
merged 4 commits into from
Feb 21, 2024
Merged

download a re-run folder, and it gets rendered images too. #210

merged 4 commits into from
Feb 21, 2024

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Feb 2, 2024 •
edited
Loading

Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com

I noticed that downloads were being rendered right at the end of the process.

When I downloaded a test which has multiple re-run attempts, I only saw one rendering of the images... because the '.' folder was being used.

I fixed it now to show this:

>../bin/galasactl-darwin-arm64 runs download --name C20339 --force        
GAL2501I: Downloaded 5 artifacts to folder 'C20339-1'
GAL2502I: Rendered 0 image files in folder 'C20339-1'
GAL2501I: Downloaded 5 artifacts to folder 'C20339-2'
GAL2502I: Rendered 0 image files in folder 'C20339-2'
GAL2501I: Downloaded 5 artifacts to folder 'C20339-3'
GAL2502I: Rendered 0 image files in folder 'C20339-3'

and this when I download a test which actually has images inside:

>../bin/galasactl-darwin-arm64 runs download --name C20324 --force 
GAL2501I: Downloaded 303 artifacts to folder 'C20324'
GAL2502I: Rendered 2142 image files in folder 'C20324'

@techcobweb
download a re-run folder, and it gets rendered images too.
aa8888d 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-210-4w5fr for details. If you are unable to do so, please contact a member of the Galasa team.

@techcobweb
better image render info msg
c68953f 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-210-kgtpx for details. If you are unable to do so, please contact a member of the Galasa team.

@techcobweb
catch this branch up to main
a6914a7 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb
empty to force a build
8957596 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@techcobweb techcobweb merged commit f092c0e into main Feb 21, 2024
4 checks passed
@techcobweb techcobweb deleted the mcobbett-render-images-on-test-re-run-folders-too branch February 21, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamansour eamansour eamansour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techcobweb @galasa-team @eamansour